Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Textarea adjustments #413

Merged
merged 23 commits into from
Dec 7, 2020
Merged

[Feature] Textarea adjustments #413

merged 23 commits into from
Dec 7, 2020

Conversation

ketsappi
Copy link
Contributor

@ketsappi ketsappi commented Nov 27, 2020 •
edited
Loading

Description

Textarea

  • Remove from components level
  • Change to use AutoId to generate id, instead of idGenerator
  • Change to use internal components for label-, hint- and status texts
  • Fix the empty space bug with aria-describedby
  • Add more tests
  • Add fullWidth prop
  • Add containerProps prop
  • Add default width for Textarea, 290px (same as for TextInput)
  • Change placeholder attribute tone omitted as we have the visualPlaceholder prop for this.

Other

  • Add missing color tokens to suomifi-ui-components/src/core/theme/colors.ts
    • depthDark2
    • depthDark3
  • Add getAriaDescribedByProp helper to src/utils/aria.ts
  • Move existing aria utils from src/components/utils/aria.ts level to src/utils/aria.ts

Motivation and Context

To better work with SSR setup and to increase developer experience by removing duplicate code (by using internal components)

How Has This Been Tested?

  • Locally in styleguidist with VoiceOver
  • In next.js (SSR) with VoiceOver

Release notes

  • Breaking changes: Style classnames changes for Textarea's labelText, hintText and statusText
  • Fix the empty space bug with aria-describedby on Textarea
  • Add fullWidth and containerProps props for Textarea

@ketsappi ketsappi added bug Something isn't working enhancement New feature or request DX Refactoring for maintainability labels Nov 27, 2020
@ketsappi
Add status prop for StatusText component
43f59b9 
Remove status text style to change color on error, as it will become automatically from StatusText component
@ketsappi ketsappi marked this pull request as ready for review November 27, 2020 12:44
@ketsappi
Remove the renaming of resize prop to indicate the discarding it
b575a15 
Resize prop is used only on the baseStyles, so that is the reason why it is not used when it is destructured from props.
LJKaski
LJKaski previously approved these changes Dec 1, 2020
View reviewed changes
@ketsappi
Add aria util for ariaDescribedBy
330e675 
Able to use the same in existing and new places
@ketsappi
Add fullWidth prop to Textarea
64b5525
@ketsappi
Add containerProps for Textarea
9b7970e 
Able to e.g to give custom style to container and specify fixed width.
@ketsappi
Update test of aria describedby
aaa545d 
Add undefined in the middle to ensure that no extra space/whitespace is added between.
@ketsappi
Change to use string format to tell the width for Textarea
c381c40 
Used in test and example of the use case. Changed to be consistent with the style with existing places; TextInput and SearchInput
@ketsappi ketsappi merged commit 2fd08c9 into develop Dec 7, 2020
@ketsappi ketsappi deleted the feature/textarea-adjustments branch December 7, 2020 10:30
@aappoalander aappoalander mentioned this pull request Dec 17, 2020
Merged
@aappoalander aappoalander mentioned this pull request Jan 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aappoalander aappoalander aappoalander approved these changes

@LJKaski LJKaski Awaiting requested review from LJKaski LJKaski is a code owner

Assignees
No one assigned
Labels
bug Something isn't working DX Refactoring for maintainability enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ketsappi @aappoalander @LJKaski