[Feature] Update suomifi-icons and suomifi-design-tokens dependencies #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ketsappi
previously approved these changes
Nov 13, 2020
ketsappi
previously approved these changes
Nov 13, 2020
LJKaski
force-pushed
the
feature/update-icons-and-tokens
branch
from
a8b1479 to
483277f
Compare
ketsappi
approved these changes
Nov 13, 2020
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were some recent updates and changes to the suomifi-icons and suomifi-design-tokens. This PR implements those changes to the ui-components.
Most noticeable changes:
depthDark2 was implemented in the placeholder texts of input elements and depthDark3 replaced the border color in form elements.
Motivation and Context
The library needs to stay up to date with the changes in the style guide.
How Has This Been Tested?
Tested by automated tests and by running locally. Should still be tested in different projects and environments, since some dependencies were changed in the underlying libraries.
Release notes
Breaking change: changes to color token values
Other changes: new tokens and icons due to updated suomifi-icons and suomifi-design-tokens