[Feature] Upgrade dependencies to latest #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…earchInput baseStyles.
aappoalander
added
enhancement
LJKaski
approved these changes
Nov 9, 2020
ketsappi
approved these changes
Nov 9, 2020
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades all but webpack and TSDX css/scss related plugins to latest available version. Also related peer dependencies have been upgraded to the latest proven to work versions. These upgrades introduce a breaking change for styled-components types to add support for TS 4 and also gain performance and security improvements. These types include a known issue with skipLibCheck true compiler option, but a workaround is described in Readme.
Motivation and Context
To allow use of TypeScript 4 and later with skipLibCheck true compiler option, some dependencies had to be upgraded. Previously used types version 4.1.8 for styled-components had to be updated to latest available version, which has a known issue of including conflicting react-native types, but fortunately there is a workaround for the issue. Another reason for upgrade is that Styled Components v5 performs better than v4 and does not introduce breaking changes.
Jest related libraries are manually configured to use latest version in contrast to what is officially supported by TSDX. This is because of security issues in older versions.
Styleguidist does not allow upgrading webpack to version 5+ and related plugins also need to remain 4.x compatible. TSDX css/scss related plugins cannot be upgraded either.
How Has This Been Tested?
Tested with Styleguidist, CRA TS and SSR test projects and using multiple browsers.
Release notes