Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] LanguageMenu text wrapping #408

Merged
merged 5 commits into from
Nov 12, 2020
Merged

Conversation

ketsappi
Copy link
Contributor

@ketsappi ketsappi commented Nov 2, 2020

Description

Long text will now wrap more nicely in the LanguageMenu

  • In the button that opens the menu
  • ...and in the opened menu

Motivation and Context

Long text was not wrapping as wanted on the LanguageMenu.

How Has This Been Tested?

  • Locally in styleguidist

Screenshots:

LanguageMenu_wrap

In the screenshot the area circled shows the gap that is intentionally left on the left side, so that menu is not "touching" the edge.

Release notes

Fix wrapping of long text in the LanguageMenu (#408)

@ketsappi ketsappi marked this pull request as draft November 2, 2020 06:32
@ketsappi ketsappi changed the title [Fix] Languageenu text wrapping [Fix] LanguageMenu text wrapping Nov 2, 2020
@ketsappi ketsappi added the bug Something isn't working label Nov 2, 2020
aappoalander
aappoalander previously approved these changes Nov 9, 2020
@aappoalander aappoalander self-requested a review November 9, 2020 10:38
To work better with mobile margin
@ketsappi ketsappi marked this pull request as ready for review November 9, 2020 11:49
@ketsappi ketsappi merged commit f54388e into develop Nov 12, 2020
@ketsappi ketsappi deleted the fix/languagemenu-text-wrapping branch November 12, 2020 09:38
@aappoalander aappoalander mentioned this pull request Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants