Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Toggle focus styles not applied to first instance #362

Merged
merged 2 commits into from
Jun 15, 2020

Conversation

LJKaski
Copy link
Collaborator

@LJKaski LJKaski commented Jun 15, 2020

Description

Toggle had a bug where the first instance of Toggle following some other element had incorrect focus styles. This was due to an erroneous CSS selector, which this PR fixes.

Motivation and Context

Component default styles need to be uniform and correct in all situations.

How Has This Been Tested?

Running locally (only styleguidist).

Release notes

Fixed a bug in Toggle focus style logic

@LJKaski LJKaski added the bug Something isn't working label Jun 15, 2020
@LJKaski LJKaski added this to the 1.0.0 milestone Jun 15, 2020
@LJKaski LJKaski requested review from aappoalander and ketsappi June 15, 2020 12:04
@LJKaski LJKaski self-assigned this Jun 15, 2020
@netlify
Copy link

netlify bot commented Jun 15, 2020

Deploy preview for gallant-mahavira-de9f7b ready!

Built with commit 7a1d221

https://deploy-preview-362--gallant-mahavira-de9f7b.netlify.app

Copy link
Contributor

@ketsappi ketsappi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

  • Tested with the styleguidist on local development setup when using only one Toggle and then also with the normal setup of multiple toggle examples
  • Tested with CRA JS project and now seems to work correctly

@ketsappi ketsappi merged commit 2e44ec6 into develop Jun 15, 2020
@aappoalander aappoalander mentioned this pull request Jun 26, 2020
@aappoalander aappoalander deleted the bugfix/toggle-focus-styles branch December 4, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants