Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Button style fixes #357

Merged
merged 6 commits into from
Jun 11, 2020
Merged

[Fix] Button style fixes #357

merged 6 commits into from
Jun 11, 2020

Conversation

ketsappi
Copy link
Contributor

Description

  • Fixes the invert text shadow to have opacity of 50%
  • Disabled Button text-shadow to have opacity of 50%
  • Disabled Button icon is now showing correct cursor, not-allowed
  • Disabled inverted button opacity changed from 50% to 41% to match with the design
  • Button icon color is now using the currentColor so that it will use same color as the text

Motivation and Context

Wanted to match the Button styles with the design.

How Has This Been Tested?

Locally ran in Styleguidist on Brave.

Release notes

Fix

  • Button text-shadow and icon color changes.

@ketsappi ketsappi added the bug Something isn't working label Jun 10, 2020
@ketsappi ketsappi requested review from aappoalander and LJKaski June 10, 2020 10:38
@netlify
Copy link

netlify bot commented Jun 10, 2020

Deploy preview for gallant-mahavira-de9f7b ready!

Built with commit 0b7450a

https://deploy-preview-357--gallant-mahavira-de9f7b.netlify.app

@ketsappi ketsappi merged commit 719e1bf into develop Jun 11, 2020
@aappoalander aappoalander mentioned this pull request Jun 26, 2020
@aappoalander aappoalander deleted the fix/button-style-fixes branch December 4, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants