Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] CheckBox hintText to use different color token #352

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

ketsappi
Copy link
Contributor

@ketsappi ketsappi commented Jun 9, 2020

Description

Changed the CheckBox hintText to use different color token: depthBase --> depthDark1

Motivation and Context

Using the color that was in the design. The wrong color was noticed as it was not accessible, because of it's low contrast.

How Has This Been Tested?

Ran in local styleguidist.

Release notes

Fix

  • Checkbox hintText color changed

@ketsappi ketsappi added the bug Something isn't working label Jun 9, 2020
@ketsappi ketsappi requested review from aappoalander and LJKaski June 9, 2020 05:49
@netlify
Copy link

netlify bot commented Jun 9, 2020

Deploy preview for gallant-mahavira-de9f7b ready!

Built with commit 40db945

https://deploy-preview-352--gallant-mahavira-de9f7b.netlify.app

LJKaski
LJKaski previously approved these changes Jun 9, 2020
aappoalander
aappoalander previously approved these changes Jun 9, 2020
@ketsappi ketsappi dismissed stale reviews from aappoalander and LJKaski via 40db945 June 9, 2020 07:01
@ketsappi ketsappi force-pushed the fix/checkbox-hintText-color branch from 5051c17 to 40db945 Compare June 9, 2020 07:01
@ketsappi ketsappi requested review from aappoalander and LJKaski June 9, 2020 07:01
@ketsappi ketsappi merged commit 3bcb349 into develop Jun 9, 2020
@ketsappi ketsappi mentioned this pull request Jun 9, 2020
@aappoalander aappoalander deleted the fix/checkbox-hintText-color branch December 4, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants