[Feature] Align toggle styles with style guide #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for gallant-mahavira-de9f7b ready! Built with commit f069977 https://deploy-preview-336--gallant-mahavira-de9f7b.netlify.app |
aappoalander
force-pushed
the
feature/align-toggle-styles-with-styleguide
branch
from
dea8f46 to
2d39f9f
Compare
aappoalander
changed the title
ketsappi
previously approved these changes
May 25, 2020
LJKaski
reviewed
May 25, 2020
aappoalander
force-pushed
the
feature/align-toggle-styles-with-styleguide
branch
from
d4029c4 to
50677d5
Compare
|
Tested with Safari, Chrome, Brave and Firefox and all seem to work in a consistent manner now. |
ketsappi
approved these changes
May 26, 2020
LJKaski
approved these changes
May 26, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aligns Toggle component styles with style guide. Focus styles have now rounded corners and only focus on toggle button / input instead of label also. Positioning of the toggle knob has been slightly adjusted. A stronger shadow is also present.
Due to the changes, the component width changes slightly.
How Has This Been Tested?
Tested with Create react app Typescript project and styleguidist build.