[Bugfix] Align textinput and searchinput styles with design #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ketsappi
previously approved these changes
May 15, 2020
LJKaski
force-pushed
the
bugfix/alignt-textinput-styles-with-design
branch
from
a224ae8 to
e6a19e4
Compare
ketsappi
previously approved these changes
May 15, 2020
aappoalander
approved these changes
May 15, 2020
ketsappi
approved these changes
May 15, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aligns the TextInput and SearchInput styles to the design. Some larger rebuilding still remains in the searchinput, but that's outside of the scope of this PR.
While adjusting styles, a couple of related matters got sorted. The statustext element is now conditionally rendered depending on if it has content or not. Also, the button in the styleguidist example was changed to suomifi button.
Motivation and Context
Textinput and searchinput had styles that differed from the latest designs.
How Has This Been Tested?
Running locally and manually testing.