[Feature] Align button styles with style guide #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aappoalander
commented
May 12, 2020
aappoalander
force-pushed
the
feature/align-button-styles-with-styleguide
branch
from
304f90d to
ec28883
Compare
ketsappi
previously approved these changes
May 12, 2020
LJKaski
previously approved these changes
May 13, 2020
aappoalander
force-pushed
the
feature/align-button-styles-with-styleguide
branch
from
ec28883 to
79ba7cb
Compare
LJKaski
approved these changes
May 14, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Button styles now match the style guide. Adjustments to paddings, colors and font-size. No changes to component APIs. Includes improvements to gradient color names.
Motivation and Context
Some components had not been updated when style guide updates were introduced. These components now have to be aligned with style guide.
How Has This Been Tested?
Since APIs were not changed, testing with styleguidist should be sufficient. No issues found during testing locally with styleguidist or build.