[Fix] Focus style align with style guide #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aappoalander
force-pushed
the
fix/focus-style-align-with-styleguide
branch
from
d19b615 to
086b7bf
Compare
LJKaski
approved these changes
May 7, 2020
| @@ -1,4 +1,4 @@ | |||
| export const radius = { | |||
| basic: '2px', | |||
| focus: '4px', | |||
| focus: '2px', | |||
There was a problem hiding this comment.
I think the 4px radius is closer to the current design if that's a viable value otherwise.
The 4px radius does not work as well as in the designs. The distance from the component border does not remain constant so I'd stick with the current value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update for current focus styles so that they match the new style guide focus styles.
Motivation and Context
Current focus styles were following the design system specification which was never taken into use outside design system implementation. This was blocking ui-components usage in projects. Focus styles were redesigned to better match default styles that are in use in may services and applications.
How Has This Been Tested?
Tested using styleguidist and Create React App TypeScript version with long contents for components.