Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Mouse cursor change for disabled Button #236

Merged
merged 3 commits into from
Nov 13, 2019

Conversation

ketsappi
Copy link
Contributor

@ketsappi ketsappi commented Nov 8, 2019

Description

When hovering mouse over disabled button, mouse cursor will now change to give better feedback to the user.

Related Issue

Related #228
This PR will add the disabled cursor only for the Button-component. Other components will be changed in later PRs.

Motivation and Context

To give better feedback for the user when the component is in disabled state.

How Has This Been Tested?

  • yarn test
  • yarn validate
  • manually testing with browser

J-Kallunki
J-Kallunki previously approved these changes Nov 12, 2019
Snapshots updated; PanelExpansion uses Button so therefore the other snapshots were also updated
@ketsappi ketsappi force-pushed the patch/mouse_cursor_disabled_button branch from 7053fe5 to 605c643 Compare November 12, 2019 09:13
@J-Kallunki J-Kallunki self-requested a review November 12, 2019 09:51
@ketsappi ketsappi merged commit 875eb35 into develop Nov 13, 2019
@ketsappi ketsappi deleted the patch/mouse_cursor_disabled_button branch June 9, 2020 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants