Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR to the PR: This prevents masked-mods from masking implicit modifiers.
This enables configs that bind a mod-morph to things like
LS(LC(U))
. The proposed change will send implicitly specified modifiers even when included in themasked_mods
argument. There are two advantages:EDIT: I added a few more additional tweaks to the PR:
trigger_mods
masked_mods
tomods
if unspecified by the user. This resolves the issues raised in when using mod-morph to make shift-backspace work as delete, the shift key is not 'swallowed' zmkfirmware/zmk#683EDIT: Closed after discussing with Pete on discord and deciding that it might be better to open a new PR with the changes. Link to the new PR: zmkfirmware#1412