Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mask implicit mods #1

Closed
wants to merge 12 commits into from

Conversation

urob
Copy link

@urob urob commented Jul 19, 2022

Small PR to the PR: This prevents masked-mods from masking implicit modifiers.

This enables configs that bind a mod-morph to things like LS(LC(U)). The proposed change will send implicitly specified modifiers even when included in the masked_mods argument. There are two advantages:

  1. The current behavior which masks out implicit modifiers that are explicitly specified as part of the binding is unintuitive. See the review comments by @slashfoo on the PR
  2. It provides a way to bind macros that (at some point) make use of a masked-mod. This is essential, for example, for implementing shifted/unshifted unicode pairs via ZMK macros (see here for an example)

EDIT: I added a few more additional tweaks to the PR:

EDIT: Closed after discussing with Pete on discord and deciding that it might be better to open a new PR with the changes. Link to the new PR: zmkfirmware#1412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant