refactor: separate SimpleSwitch component using Vue SFC (#1033) #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Map1en
commented
Dec 27, 2024
•
Map1en
commented
- Separate SimpleSwitch Component Using Vue SFC
- Separate the SimpleSwitch component from the existing Pug mixin.
- The Pug mixin was difficult to use and could not handle complex parameters or cover various possibilities, thus the switch to Vue SFC.
- Separate Default Theme Styles
- Separate the default theme styles into the component file.
- Other themes will continue to use CSS for overrides.
- This approach ensures that app.scss can be split without issues.
- Root Component Assignment Operations
- Currently, there is only one root component, so various assignment operations still need to be placed in the root component's methods.
- If the overall setting component is separated in the future, some data might also be separated.
- Added Required Packages
- Added vue-loader and vue-template-compiler, which are necessary packages for using SFC.
# Conflicts: # html/src/mixins/tabs/settings.pug # html/src/theme.material3.scss
Map1en
added a commit
to Map1en/VRCX
that referenced
this pull request
Dec 27, 2024
Natsumi-sama
pushed a commit
that referenced
this pull request
Dec 30, 2024
Natsumi-sama
pushed a commit
to Natsumi-sama/VRCX
that referenced
this pull request
Dec 30, 2024
…#1047) * fix: issues caused by PR(vrcx-team#1034). (vrcx-team#1033) * Manually merge to ensure compatibility with (vrcx-team#1054) PR
Natsumi-sama
pushed a commit
to Natsumi-sama/VRCX
that referenced
this pull request
Jan 9, 2025
…) (vrcx-team#1054) * refactor: separate SimpleSwitch component using Vue SFC * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.