Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements several basic search types, bumps major version #42

Merged
merged 14 commits into from
Sep 19, 2020
Merged

Implements several basic search types, bumps major version #42

merged 14 commits into from
Sep 19, 2020

Conversation

kyland-holmes
Copy link
Contributor

Hi @vrcmarcos ,

I've made some updates to get this working for some basic terms, match, filter, and bool queries. Would greatly appreciate your review and feedback. Feel free to tag others on the review as well.

@coveralls
Copy link

coveralls commented Aug 11, 2020

Coverage Status

Coverage decreased (-0.6%) to 98.611% when pulling 977270d on KyKoPho:master into 646b214 on vrcmarcos:master.

Copy link
Owner

@vrcmarcos vrcmarcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KyKoPho, sorry for the delay on this review. Your change looks awesome! I have just a small comment regarding the TOX usage, but it's not a big deal. I'll approve this change and maybe we can fix this in a different PR :)


test: test_install
@tox -p 20 --parallel--safe-build
python3 setup.py test
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wdyt of keep the TOX tool here to test against different environments?

@vrcmarcos vrcmarcos merged commit c7d2909 into vrcmarcos:master Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants