-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements several basic search types, bumps major version #42
Conversation
Adds implementation of terms query
bump version to 2.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KyKoPho, sorry for the delay on this review. Your change looks awesome! I have just a small comment regarding the TOX usage, but it's not a big deal. I'll approve this change and maybe we can fix this in a different PR :)
|
||
test: test_install | ||
@tox -p 20 --parallel--safe-build | ||
python3 setup.py test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wdyt of keep the TOX tool here to test against different environments?
Hi @vrcmarcos ,
I've made some updates to get this working for some basic terms, match, filter, and bool queries. Would greatly appreciate your review and feedback. Feel free to tag others on the review as well.