Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the FakeElasticsearch __init__ signature match the one from Elasticsearch #10

Merged
merged 3 commits into from
Jul 24, 2018
Merged

Make the FakeElasticsearch __init__ signature match the one from Elasticsearch #10

merged 3 commits into from
Jul 24, 2018

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Mar 20, 2018

Also make it work on modern python3.

xrmx added 2 commits March 20, 2018 10:49
@xrmx
Match Elasticsearch __init__ signature in FakeElasticSearch
2b3e285 
Fortunately it hasn't changed from 1.1 to latest master.
@xrmx
Make FakeElasticsearch work with modern python 3
6b1cb21 
As unicode() is not there anymore
@coveralls
Copy link

coveralls commented Mar 20, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 98.63% when pulling 63018b4 on xrmx:matchesinitsignature into d115956 on vrcmarcos:master.

@vrcmarcos vrcmarcos merged commit 7bda492 into vrcmarcos:master Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xrmx @coveralls @vrcmarcos