Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues around configuration changes #3

Open
wants to merge 1 commit into
base: handle-configuration-change-using-onSavedInstance
Choose a base branch
from

Conversation

BenHenning
Copy link

Specifically:

  • Uses add() again instead of replace() for ExplorationFragment
  • Avoids submitting wrong answers (which avoids a hideKeyboard() crash)
  • Stores the current answer error (if any) in RawUserAnswer so that it can be restored (required moving AnswerErrorCategory to be a proto enum)
  • Generically restores both real-time and submit-time errors

No test changes have been included in this commit.

Specifically:
- Uses add() again instead of replace() for ExplorationFragment
- Avoids submitting wrong answers (which avoids a hideKeyboard() crash)
- Stores the current answer error (if any) in RawUserAnswer so that it
can be restored (required moving AnswerErrorCategory to be a proto enum)
- Generically restores both real-time and submit-time errors

No test changes have been included in this commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant