Allow WSDL to be loaded from HTTPS sites #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jimmyjones2 Can you think of an easy way to test this? I'm fine merging as is, but wanted to know. |
|
Did you just want an example? Paypal SOAP API uses https for WSDL, eg. https://www.sandbox.paypal.com/wsdl/PayPalSvc.wsdl |
|
If that's a constant source that will not change, then yes, please add a test for it. I don't want your hard work to go to waste by getting broken in future changes. |
jsdevel
added a commit
that referenced
this pull request
Sep 16, 2015
Allow WSDL to be loaded from HTTPS sites
|
Thanks for the PR @jimmyjones2 ! It would be really hard to maintain the tests for this change, so I merged it. If you can add tests later, pleast submit a PR. |
diarmaidm
pushed a commit
to diarmaidm/node-soap
that referenced
this pull request
Feb 3, 2016
Allow WSDL to be loaded from HTTPS sites
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.