Add ability to customize http client/request lib #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for time & effort @raymondfeng - we appreciate it a lot 👍 Could you please open another Pull Request and provide a guideline/some more context on this newly introduced (and in my opinion super valuable) feature in our README once this got merged? This would be awesome! |
herom
added a commit
that referenced
this pull request
May 26, 2015
Add ability to customize http client/request lib
|
@herom Thank you for the quick response. I'll update the README. |
This was referenced May 26, 2015
diarmaidm
pushed a commit
to diarmaidm/node-soap
that referenced
this pull request
Feb 3, 2016
…quest Add ability to customize http client/request lib
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the http client into a class and add options to customize the
httpClientorrequest. It makes the module extensible. In my case, I need this change for two purposes: