Respect empty soap actions in operations #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The jshint rules are quite strict so the Travis build fails because of wrong indentation... If you change to two-space then the proper tests can run |
|
@simonjosefsson strangely, my system's jshint doesn't seem to pick up any indentation issues. They are fixed now. |
|
Thanks a lot for your contribution @akagr 👍 In order to be able to merge your PR, please follow the Guidelines on Submitting a Pull Request, which in your particular case means, that we'd need you to squash your commits into a single one and please don't just close this PR and open a new one but instead follow the quite awesome GitHub help over here and here on squashing commits 😺 |
akagr
force-pushed
the
feature/empty-SOAP-Action
branch
from
5fee307
to
8c931eb
Compare
|
@herom squashed |
|
Thanks a lot @akagr 😃 : |
herom
added a commit
that referenced
this pull request
Feb 7, 2015
Respect empty soap actions in operations
diarmaidm
pushed a commit
to diarmaidm/node-soap
that referenced
this pull request
Feb 3, 2016
Respect empty soap actions in operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a nasty situation in which the soapActions were empty in wsdl. I suggest we respect those cases and not force a soap action there. It leads to
The given SOAPAction http://abc.xsd/myaction does not match an operationsituation.