Add support for message and request events as per issue #545 #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for only noticing that the CI build failed. I've updated and it's passing now. Hoping you guys can merge this and publish to NPM soon :) |
Fix linting errors in newly added tests.
|
thanks a lot @evanshortiss 👯 |
herom
added a commit
that referenced
this pull request
Feb 4, 2015
Add support for message and request events as per issue #545
|
Awesome, thank you! Also TIL: Rebase 🎉 |
diarmaidm
pushed a commit
to diarmaidm/node-soap
that referenced
this pull request
Feb 3, 2016
Add support for message and request events as per issue #545
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in two events that are emitted by Client instances; "message" and :"request". Both are emitted immediately before the SOAP request is sent.
"message" contains the Soap Body contents.
"request" contains the entire Soap request contents.
"message" is useful if you need to log requests but have username/password info in the header etc.
Tests updated also.