Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Remove execute privileges on files. #216

Merged
merged 1 commit into from
Jan 22, 2014

Conversation

jsdevel
Copy link
Collaborator

@jsdevel jsdevel commented Jan 22, 2014

No description provided.

@jsdevel
Copy link
Collaborator Author

jsdevel commented Jan 22, 2014

@alanbly Is there a valid reason why the file permissions were changed to 755?

I'd rather they be changed back for the following reasons:

  1. None of the files changed have interpreter directives that would allow the files to be executed on their own.
  2. Adding execute permissions is dangerous, as you can have unintended results should the default interpreter be used and you have some command that wipes out the current directory.
  3. It's very uncommon to assign the execute bit on a file that doesn't need it.

/cc @vpulim

@alanbly
Copy link
Contributor

alanbly commented Jan 22, 2014

I'm sure this was an issue with my environment (where this repo sits in situ with an SVN repo) that I did not intend to propagate.

alanbly added a commit that referenced this pull request Jan 22, 2014
Cleanup:  Remove execute privileges on files.
@alanbly alanbly merged commit 0194a5b into vpulim:master Jan 22, 2014
@jsdevel
Copy link
Collaborator Author

jsdevel commented Jan 22, 2014

Thanks!

@jsdevel jsdevel deleted the change-file-permissions branch January 22, 2014 22:52
diarmaidm pushed a commit to diarmaidm/node-soap that referenced this pull request Feb 3, 2016
Cleanup:  Remove execute privileges on files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants