-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support binary data in MTOM #1245
Conversation
Hi @CyBot, New feature should not be used by default, please make it optional. And this did not pass lint check, should be fixe as well. |
IMO it should be the default, because currently it's not working correctly. The whole point of MTOM is sending binary data. P.S.: I'll look into the failing test |
The feature that is breaking the test now was not working. |
I fixed the tests - they now pass the attachment body as a buffer, not a ReadStream. The test fix should maybe go into a separate commit, I can split them and create a separate PR if requested |
Uncomment test code that was disabled when migrated from Request to Axios.
Hi @CyBot, Could you allow me to push to your forked repo? I made some changes in the tests. In general, it looks good, seems like it works as expected now. |
@CyBot I pushed some changes, added additional assertion on server side and uncommented assertions that were disabled some time ago. |
Approved, I will include this into next release. Thanks for the fix. |
converted the body data to a string, making it impossible to send binary data