typeStorageを確実に参照するようにする #1230
Open
typeStorageを確実に参照するようにする #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To make it easier to understand could you translate this to English and explain why do you need this change? Also, if it is possible please cover changes with the tests. |
|
From deepl: """ Tentatively solved the problem that xmlToObject for ltea does not convert array types as arrays. Not sure if that helps 🤷 but I was curious :) |
smokhov
reviewed
Oct 4, 2024
| const typeName: string = type.name; | ||
| if(typeName in typeStorage){// typeにtypeNameが入ってしまった場合の対応、本来はこのようなことが起きないように対処すべきかもしれない。 |
There was a problem hiding this comment.
"// typeName in type, perhaps this should be handled to prevent this from happening in the first place."
w666
reviewed
Oct 7, 2024
| const typeName: string = type.name; | ||
| if(typeName in typeStorage){// typeにtypeNameが入ってしまった場合の対応、本来はこのようなことが起きないように対処すべきかもしれない。 | ||
| if (this.$ref) { | ||
| element = typeStorage[typeName]; |
There was a problem hiding this comment.
Probably, need to check that typeStorage[typeName] has a value, could be undefined, null ... anything
w666
requested changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alteaに対するxmlToObjectで配列型を配列として変換してくれない問題を暫定的に解消。
node-soap的に望ましい実装ではなさそうだが...。