Improvement when there is no explicit Body in the request #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please, which tool do you use to format the code. My IDE change much more than needed. |
w666
requested changes
Oct 24, 2024
| } | ||
|
|
||
| function getDateString(d) { | ||
| function pad(n) { | ||
| return n < 10 ? '0' + n : n; | ||
| return n < 10 ? "0" + n : n; |
There was a problem hiding this comment.
Code style should not be changed, this makes it hard to review and does not provide any benefits. Please, revert styling changes and leave only actual changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have improved the input request parsing when there is no explicit body in the initial request Xml.