Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed double await in async and fixed response #1185

Merged
merged 2 commits into from
May 18, 2022
Merged

Removed double await in async and fixed response #1185

merged 2 commits into from
May 18, 2022

Commits on May 16, 2022

  1. Removed double await in async 

    There's no need to call await again on the result object since result is already resolved.
    @anasik
    anasik authored May 16, 2022
    Configuration menu
    Copy the full SHA
    f39059a View commit details
    Browse the repository at this point in the history

  2. Returning just the JSON response in await example 

    In the example for async, logging result returns an array containing not just the JSON response but also the rawResponse, rawRequest e.t.c. 
This can be confusing for users who try the async example after trying the non-async examples which only return the JSON response. 

I added a subscript to the 0th index so that that's what's logged.
    @anasik
    anasik authored May 16, 2022
    Configuration menu
    Copy the full SHA
    c2897cd View commit details
    Browse the repository at this point in the history