Upgrade formidable to v2 #1183
Merged
Upgrade formidable to v2 #1183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vpulim ping |
|
need the build to pass |
|
The failure doesn't look related to my change. It looks the same as in #1180. |
|
@orgads i know you didn't cause it. i'm mainly a PR reviewer and publisher. if you have time to fix it on master i'd greatly appreciate it |
v1 is deprecated.
|
Rebased. Please review. |
|
The update to this version now breaks our webpack build and accordingly to formidable, updating to version 3 fixes the issue. Is there any reason why you didn't choose to update to version 3 instead? |
|
I used |
|
Fair enough, I've followed up with their team to see what's the status. Thanks! |
sandrozbinden-axa
pushed a commit
to axa-health/node-soap
that referenced
this pull request
Oct 6, 2022
v1 is deprecated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1 is deprecated.