Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change axios to be a peer dependency #1179

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Change axios to be a peer dependency #1179

merged 1 commit into from
Jan 14, 2022

Commits on Jan 12, 2022

  1. Change axios to be a peer dependency 

    The usage of axios in this repository is very basic, but its versioning
is defined very tightly. This causes problems, because the interface
IOptions uses AxiosInstance as its property, preventing the clients of
this library from updating their axios version beyond the limits set in
this library. Typescript compiler gives type error when giving higher
version AxiosInstance for IOptions.

By setting axios as a peer dependency, we would allow the clients of
this library to install other versions of axios if they so choose.
    @ssiltanen
    ssiltanen committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    eb0e8fd View commit details
    Browse the repository at this point in the history