change content-type-parser to whatwg-mimetype #1169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@lagden sorry for the late reply, can you resolve the conflicts? |
|
done |
|
@lagden please ensure the build passes |
|
Hi guys. Just wondering is there a plan to fix this and would you have a date in mind? Thanks |
|
waiting on the build to be fixed. @lagden can you fix it? |
|
@jsdevel - Not able to fix the build issue with these code changes. Please assist us to fix this issue. Our project is impacted due to this issue. |
|
@khadeamolm you'll have to dig into it and fix it. |
jsdevel
pushed a commit
that referenced
this pull request
Jan 5, 2022
…1177) * change content-type-parser to whatwg-mimetype * Readme.md: Rewrite how to get support for conciseness, update mentions of the old request module to Axios, improve documentation of several functions' arguments. * Reorder the import from 'whatwg-mimetype' to be alphabetized. The upstream pull request 1169 failed linting with the following error: ERROR: /home/runner/work/node-soap/node-soap/src/http.ts:9:1 - Import sources within a group must be alphabetized. * Add @types/whatwg-mimetype as a developer dependency. * HttpClient.request(): Change the call to MIMEType's constructor method to MIMEType.parse(). The MIMEType constructor method throws an Error object on failure, unlike the call to contentTypeParser() from the 'content-type-parser' package, which returned null on failure. To maintain backwards compatibility, use MIMEType.parse(), which returns null on failure. * http.ts: Change the import syntax for MIMEType to be compatible with TypeScript. * HttpClient.request(): Fix the code that gets the boundary parameter from the parsed HTTP Content-Type header. Co-authored-by: Thiago Lagden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regular Expression Denial of Service (ReDoS)
https://snyk.io/test/npm/content-type-parser/1.0.2