Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed chessboard references #895

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

Shivansh20128
Copy link
Contributor

@Shivansh20128 Shivansh20128 commented Nov 16, 2024

Description

This PR fixes the references for the states/chessboard.py as discussed in the mentioned issue.
#Closes #843

Changes

  • Added "Bruß_2000_Construction" reference in refs.bib
  • Modified reference in chessboard.py

Checklist

Before marking your PR ready for review, make sure you checked the following locally. If this is your first PR, you might be notified of some workflow failures after a maintainer has approved the workflow jobs to be run on your PR.

Additional information is available in the documentation.

  • Use ruff for errors related to code style and formatting.
  • Verify all previous and newly added unit tests pass in pytest.
  • Check the documentation build does not lead to any failures. Sphinx build can be checked locally for any failures related to your PR
  • Use linkcheck to check for broken links in the documentation
  • Use doctest to verify the examples in the function docstrings work as expected.

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.9%. Comparing base (c5d23d6) to head (ff27f70).
Report is 2 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #895   +/-   ##
======================================
  Coverage    97.9%   97.9%           
======================================
  Files         168     168           
  Lines        3293    3293           
  Branches      721     721           
======================================
  Hits         3225    3225           
  Misses         44      44           
  Partials       24      24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vprusso
Copy link
Owner

vprusso commented Nov 16, 2024

That's great work, @Shivansh20128 !

LGTM, and thank you again!

@vprusso vprusso merged commit 1ef875b into vprusso:master Nov 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in reference for states.chessboard
2 participants