Fixing multiplication operator warning for extended nonlocal games. #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #824 +/- ##
========================================
- Coverage 97.8% 97.8% -0.1%
========================================
Files 167 167
Lines 3256 3254 -2
Branches 799 799
========================================
- Hits 3186 3184 -2
Misses 46 46
Partials 24 24 ☔ View full report in Codecov by Sentry. |
|
The warning is still showing up. |
Yes, but this time at least it's only applicable to NLG (as opposed to ENLG) so I'll make the same switch for that! |
purva-thakre
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the multiple warnings as shown in:
https://github.com/vprusso/toqito/actions/runs/11151893975/job/30996320621?pr=821#step:5:3446