-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github actions #238
Merged
Merged
Add github actions #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminvakil
reviewed
Aug 30, 2022
Co-authored-by: Amin Vakil <[email protected]>
SuperQ
approved these changes
Sep 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems legit.
@SuperQ @vozlt @aminvakil Finally, I could add the tests in github actions, it is quite different from first revision, so I appreciate that you all review one more, if you have any time. |
SuperQ
approved these changes
Sep 5, 2022
SuperQ
added a commit
that referenced
this pull request
Sep 5, 2022
Release [v0.2.0] - 2022-09-05 ** Bugfix - fixed for PR[#238](#238) - fixed for PR[#238](#238) - fixed issues/204 that syntax error has occured - rollback to 549cc4d - fixed issues/137, issues/98 that maxSize in cacheZones is displayed incorrectly - fixed issues/174 that XSS vulnerability in the html page Feature: added moduleVersion field in format/json - added escape strings for filter names in JSON - fixed the sum value of histogram in upstream metrics - fixed to display all A records of server without zone directive in the upstream block. ** Chore - Use git-chglog ** Comment - added moduleVersion - added additional information about cacheZones - added tested versions - added a diagram for the order of module directives ** Compatibility - fixed ngx_http_vhost_traffic_status_display_get_upstream_nelts() to calculate all A records of server. ** Docs - Fix README ** Docs - fix simple typo, destory -> destroy ** Fix - limit the r->uri search scope to avoid overflow ** Prometheus - fix nginx_vts_filter_requests_total labels - remove request "total" metrics ** Refactor - changed version - changed spacing - changed spacing - changed if statement from merged pull/145 ** Test - describe how to test and fix failed test case Signed-off-by: SuperQ <[email protected]>
Merged
SuperQ
added a commit
that referenced
this pull request
Sep 5, 2022
Release [v0.2.0] - 2022-09-05 ** Bugfix - fixed for PR[#238](#238) - fixed for PR[#238](#238) - fixed issues/204 that syntax error has occured - rollback to 549cc4d - fixed issues/137, issues/98 that maxSize in cacheZones is displayed incorrectly - fixed issues/174 that XSS vulnerability in the html page Feature: added moduleVersion field in format/json - added escape strings for filter names in JSON - fixed the sum value of histogram in upstream metrics - fixed to display all A records of server without zone directive in the upstream block. ** Chore - Use git-chglog ** Comment - added moduleVersion - added additional information about cacheZones - added tested versions - added a diagram for the order of module directives ** Compatibility - fixed ngx_http_vhost_traffic_status_display_get_upstream_nelts() to calculate all A records of server. ** Docs - Fix README ** Docs - fix simple typo, destory -> destroy ** Fix - limit the r->uri search scope to avoid overflow ** Prometheus - fix nginx_vts_filter_requests_total labels - remove request "total" metrics ** Refactor - changed version - changed spacing - changed spacing - changed if statement from merged pull/145 ** Test - describe how to test and fix failed test case Signed-off-by: SuperQ <[email protected]>
SuperQ
added a commit
that referenced
this pull request
Sep 5, 2022
Release [v0.2.0] - 2022-09-05 ** Bugfix - fixed for PR[#238](#238) - fixed for PR[#238](#238) - fixed issues/204 that syntax error has occured - rollback to 549cc4d - fixed issues/137, issues/98 that maxSize in cacheZones is displayed incorrectly - fixed issues/174 that XSS vulnerability in the html page Feature: added moduleVersion field in format/json - added escape strings for filter names in JSON - fixed the sum value of histogram in upstream metrics - fixed to display all A records of server without zone directive in the upstream block. ** Chore - Use git-chglog ** Comment - added moduleVersion - added additional information about cacheZones - added tested versions - added a diagram for the order of module directives ** Compatibility - fixed ngx_http_vhost_traffic_status_display_get_upstream_nelts() to calculate all A records of server. ** Docs - Fix README ** Docs - fix simple typo, destory -> destroy ** Fix - limit the r->uri search scope to avoid overflow ** Prometheus - fix nginx_vts_filter_requests_total labels - remove request "total" metrics ** Refactor - changed version - changed spacing - changed spacing - changed if statement from merged pull/145 ** Test - describe how to test and fix failed test case Signed-off-by: SuperQ <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSAI.
This PR can be only confirm whether it can build the nginx with this modules via the github actions.
I've given up to make test stages because a several tests which concerned about upstream zone features obviously failedI've given up to make test stages because a several tests which concerned about upstream zone features obviously failed.