Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Talk recording (when available) on talk detail screen #93

Closed
fcamblor opened this issue Apr 28, 2024 · 1 comment
Closed

Show Talk recording (when available) on talk detail screen #93

fcamblor opened this issue Apr 28, 2024 · 1 comment

Comments

@fcamblor
Copy link
Collaborator

Post conference, it would be nice to :

  • be able to trigger a youtube (or whatever video platform) crawling to automatically identify & link talks with their recording
  • once done, provide a player on the talk details screen, allowing to play recording of the talk
  • a 🎦 indicator might even be provided on talk listing screen in order to tell that a recording is available
fcamblor added a commit that referenced this issue Apr 28, 2024
…ipt to ensure we always have an empty assets array on legacy talks)
fcamblor added a commit that referenced this issue Apr 29, 2024
fcamblor added a commit that referenced this issue Apr 29, 2024
fcamblor added a commit that referenced this issue Apr 29, 2024
fcamblor added a commit that referenced this issue Apr 29, 2024
…setsRequest allowing to fill detailed talk's recording url
fcamblor added a commit that referenced this issue Apr 29, 2024
…vironment variables defined in .env.local file (provided a .env.local.sample example)
fcamblor added a commit that referenced this issue Apr 29, 2024
fcamblor added a commit that referenced this issue Apr 29, 2024
…setsRequest allowing to fill detailed talk's recording url
fcamblor added a commit that referenced this issue May 1, 2024
…vironment variables defined in .env.local file (provided a .env.local.sample example)
fcamblor added a commit that referenced this issue May 1, 2024
fcamblor added a commit that referenced this issue May 1, 2024
…setsRequest allowing to fill detailed talk's recording url
fcamblor added a commit that referenced this issue May 1, 2024
…ipt to ensure we always have an empty assets array on legacy talks)
fcamblor added a commit that referenced this issue May 1, 2024
…vironment variables defined in .env.local file (provided a .env.local.sample example)
fcamblor added a commit that referenced this issue May 1, 2024
fcamblor added a commit that referenced this issue May 1, 2024
…setsRequest allowing to fill detailed talk's recording url
fcamblor added a commit that referenced this issue May 1, 2024
fcamblor added a commit that referenced this issue May 1, 2024
fcamblor added a commit that referenced this issue May 1, 2024
…ng test fallback + considering a ratio of speakers instead of only 1 speakers matching the talk
fcamblor added a commit that referenced this issue May 1, 2024
…e+speaker doesn't work well

this can be particularly relevant for talks involving a lot of speakers which are not mentioned
(because list is too long) in youtube video title
fcamblor added a commit that referenced this issue May 1, 2024
fcamblor added a commit that referenced this issue May 1, 2024
- avoiding duplicates (different talks linked to the same youtube video) - added a unit test to enforce this
- take talks having best matching score first instead of taking them randomly
- removing already-assigned youtube talks when it comes to finding the best candidate for a talk
fcamblor added a commit that referenced this issue May 1, 2024
fcamblor added a commit that referenced this issue May 1, 2024
…a little bit orders of field to have something more debug friendly

+ aligned test data over these new changes
+ reduced timesline of dvbe23 videos so that we get less videos candidates
fcamblor added a commit that referenced this issue May 1, 2024
…red on both talk title and video title

That's something very useful in order to avoid lowering matching scores for youtube video having long
title prefixes such as 'Voxxed Days Ioannina 2024'
fcamblor added a commit that referenced this issue May 1, 2024
fcamblor added a commit that referenced this issue May 1, 2024
…ng test fallback + considering a ratio of speakers instead of only 1 speakers matching the talk
fcamblor added a commit that referenced this issue May 1, 2024
…e+speaker doesn't work well

this can be particularly relevant for talks involving a lot of speakers which are not mentioned
(because list is too long) in youtube video title
fcamblor added a commit that referenced this issue May 1, 2024
fcamblor added a commit that referenced this issue May 1, 2024
- avoiding duplicates (different talks linked to the same youtube video) - added a unit test to enforce this
- take talks having best matching score first instead of taking them randomly
- removing already-assigned youtube talks when it comes to finding the best candidate for a talk
fcamblor added a commit that referenced this issue May 1, 2024
fcamblor added a commit that referenced this issue May 1, 2024
…a little bit orders of field to have something more debug friendly

+ aligned test data over these new changes
+ reduced timesline of dvbe23 videos so that we get less videos candidates
fcamblor added a commit that referenced this issue May 1, 2024
…red on both talk title and video title

That's something very useful in order to avoid lowering matching scores for youtube video having long
title prefixes such as 'Voxxed Days Ioannina 2024'
@fcamblor
Copy link
Collaborator Author

fcamblor commented May 1, 2024

✅ done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant