Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of /eventStats endpoint + /family-tokens collection #70

Open
fcamblor opened this issue Oct 25, 2023 · 4 comments
Open

Get rid of /eventStats endpoint + /family-tokens collection #70

fcamblor opened this issue Oct 25, 2023 · 4 comments

Comments

@fcamblor
Copy link
Collaborator

In profit to /publicEventStats endpoint which provides multiple kind of accesses based on /public-token/ tokens

We will need to ensure every consumers of /publicEventStats (devoxx CFP mainly) stopped calling us prior to removing the endpoint

@fcamblor fcamblor moved this to Every consumers aligned in Voxxrin 3 Oct 25, 2023
@fcamblor
Copy link
Collaborator Author

@stephanj told me this event was no longer called from cfp.dev, we should be free to remove it

This makes me wonder if /family-token shouldn't be removed after that (the only remaining place where we might use it is on /attendeesFeedbacks and we might refactor it to use public-tokens instead)

@fcamblor fcamblor changed the title Get rid of /eventStats endpoint Get rid of /eventStats endpoint + /family-tokens collection Oct 25, 2023
@fcamblor
Copy link
Collaborator Author

Provided replacement APIs for GET /publicEventStats (splitted into GET /events/:eventId/topTalks and GET /events/:eventId/talksStats) and proposed a MR to CFP.dev implementation to get rid of this endpoint and replace it with new endpoints.
This MR has presently been merged, released (2.13.0) and deployed on every cfp.dev 2024 instances.

There is only 1 remaining caller still relying on /publicEventStats: SocialWallFX project (for displaying top talks on Devoxx BE and VoxxedDays Zurich
I contacted SocialWallFX developers to ask them to migrated to new endpoint when possible.

@fcamblor
Copy link
Collaborator Author

Note that family tokens should not longer be used (main user of these tokens was cfp.dev)

@fcamblor
Copy link
Collaborator Author

fixed deletion of family-event-tokens collection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Every consumers aligned
Development

No branches or pull requests

1 participant