#79 better error management during Express routes handling, showing e…

…rror when it occurs
voxxrin · Mar 31, 2024 · d9e035f · d9e035f
1 parent bbb105d
commit d9e035f
Showing 1 changed file with 20 additions and 4 deletions.
diff --git a/cloud/functions/src/functions/http/utils.ts b/cloud/functions/src/functions/http/utils.ts
@@ -90,7 +90,11 @@ export const Routes = {
       const stringifiedQueryParams = stringifyParams(req.query as Record<string, string>)
       exposeLogContext({ method: 'POST', route, pathParams: stringifiedPathParams, queryParams: stringifiedQueryParams }, async () => {
         debug(`POST ${route} [${stringifiedPathParams}]`)
-        await callback(res, req.params as PATH_PARAMS, req.query as QUERY_PARAMS, req.body as BODY)
+         try {
+          await callback(res, req.params as PATH_PARAMS, req.query as QUERY_PARAMS, req.body as BODY)
+        } catch(e) {
+          return sendResponseMessage(res, 500, `Unexpected Error: ${e?.toString()}`)
+        }
       })
     })
   },
@@ -106,7 +110,11 @@ export const Routes = {
       const stringifiedQueryParams = stringifyParams(req.query as Record<string, string>)
       exposeLogContext({ method: 'PUT', route, pathParams: stringifiedPathParams, queryParams: stringifiedQueryParams }, async () => {
         debug(`PUT ${route} [${stringifiedPathParams}]`)
-        await callback(res, req.params as PATH_PARAMS, req.query as QUERY_PARAMS, req.body as BODY);
+        try {
+          await callback(res, req.params as PATH_PARAMS, req.query as QUERY_PARAMS, req.body as BODY)
+        } catch(e) {
+          return sendResponseMessage(res, 500, `Unexpected Error: ${e?.toString()}`)
+        }
       })
     })
   },
@@ -121,7 +129,11 @@ export const Routes = {
       const stringifiedQueryParams = stringifyParams(req.query as Record<string, string>)
       exposeLogContext({ method: 'GET', route, pathParams: stringifiedPathParams, queryParams: stringifiedQueryParams }, async () => {
         debug(`GET ${route} [${stringifiedPathParams}]`)
-        await callback(res, req.params as PATH_PARAMS, req.query as QUERY_PARAMS);
+        try {
+          await callback(res, req.params as PATH_PARAMS, req.query as QUERY_PARAMS);
+        } catch(e) {
+          return sendResponseMessage(res, 500, `Unexpected Error: ${e?.toString()}`)
+        }
       })
     })
   },
@@ -136,7 +148,11 @@ export const Routes = {
       const stringifiedQueryParams = stringifyParams(req.query as Record<string, string>)
       exposeLogContext({ method: 'DELETE', route, pathParams: stringifiedPathParams, queryParams: stringifiedQueryParams }, async () => {
         debug(`DELETE ${route} [${stringifiedPathParams}]`)
-        await callback(res, req.params as PATH_PARAMS, req.query as QUERY_PARAMS)
+        try {
+          await callback(res, req.params as PATH_PARAMS, req.query as QUERY_PARAMS);
+        } catch(e) {
+          return sendResponseMessage(res, 500, `Unexpected Error: ${e?.toString()}`)
+        }
       })
     })
   }