Disable Style/TrailingCommaInLiteral

[ghoneycutt]

When this is enabled, trailing comma's for elements in a hash are not allowed. This is not the style that Puppet uses and causes code churn. This change would disable that functionality.

[igalic]

that's an extremely confusing behaviour for a toggle of this name

but i guess the context I'm missing to understand this name and the behaviour, is the specific tastes of the rubocop developers 🤷🏻‍♀️

[ekohl]

I actually was thinking about flipping it to consistent_comma, but disabling can be a good first step.

Note there are a few trailing comma style cops. https://docs.rubocop.org/rubocop/0.92/cops.html#department-style lists:

• Style/TrailingCommaInArguments
• Style/TrailingCommaInArrayLiteral
• Style/TrailingCommaInBlockArgs
• Style/TrailingCommaInHashLiteral

It may have changed a bit in the older version we're using, but I'd prefer to have those all with the same setting.

[alexjfisher]

Totally agree that it makes no sense to enforce one style in puppet code and the opposite in ruby code.

[ghoneycutt]

@ekohl I reviewed those cops you posted and they actually make sense as they are and are in line with puppet styling.

[ekohl]

@ghoneycutt I think it's improper to merge your own PRs if someone had a comment about it that received multiple 👍. Especially if it's just within a few hours. Either you should point out why it doesn't need to be addressed or fix it. IMHO Voxpupupli is based on collaboration and consensus. That also means giving time for a discussion.

[ghoneycutt]

@ekohl I read Alex's post and the corresponding +1's are in agreement with the change.