puppetlabs_spec_helper: require 4.x and newer #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
version 3 defines the beaker rake task. beaker-rspec defines that as well, and that's the one we want to use. We need to ensure that we load puppetlabs_spec_helper in version 4 (which doesn't have the beaker rake task). Otherwise we end up with two tasks. Calling it will run both which in turn will run all tests twice.
bastelfreak
commented
Dec 18, 2022
| @@ -30,5 +30,5 @@ Gem::Specification.new do |s| | |||
| s.add_runtime_dependency 'rspec-github', '~> 2.0' | |||
| s.add_runtime_dependency 'serverspec' | |||
| s.add_runtime_dependency 'winrm' | |||
| s.add_development_dependency 'puppetlabs_spec_helper', '>= 1.2.0' | |||
| s.add_development_dependency 'puppetlabs_spec_helper', '>= 4.0.0' | |||
There was a problem hiding this comment.
@ekohl I'm wondering if this should be a runtime dependency, not a development dependency?
|
This isn't really a bug. It's just a development dependency that accepts the newest version anyway. At runtime it's a soft dependency: voxpupuli-acceptance/lib/voxpupuli/acceptance/rake.rb Lines 1 to 7 in 993d0d0 Ideally the fixture bit would be in a gem and the spec helper would just be calling that, but it's not so here we are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version 3 defines the beaker rake task. beaker-rspec defines that as well, and that's the one we want to use. We need to ensure that we load puppetlabs_spec_helper in version 4 (which doesn't have the beaker rake task). Otherwise we end up with two tasks. Calling it will run both which in turn will run all tests twice.