Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize the code #235

Merged
merged 5 commits into from
Nov 3, 2022
Merged

Modernize the code #235

merged 5 commits into from
Nov 3, 2022

Conversation

gdubicki
Copy link
Member

@gdubicki gdubicki commented Nov 2, 2022

  • Update syntax to Python 3.7+ with pyupgrade
  • Format with black

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 84.88% // Head: 84.49% // Decreases project coverage by -0.39% ⚠️

Coverage data is based on head (0e4cc8d) compared to base (05dc619).
Patch coverage: 75.19% of modified lines in pull request are covered.

❗ Current head 0e4cc8d differs from pull request most recent head 3a2b2d2. Consider uploading reports for the commit 3a2b2d2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
- Coverage   84.88%   84.49%   -0.40%     
==========================================
  Files          14       14              
  Lines         913      890      -23     
==========================================
- Hits          775      752      -23     
  Misses        138      138              
Impacted Files Coverage Δ
pypuppetdb/api/metadata.py 75.00% <0.00%> (-5.00%) ⬇️
pypuppetdb/errors.py 100.00% <ø> (ø)
pypuppetdb/api/query.py 54.43% <45.83%> (-1.13%) ⬇️
pypuppetdb/types.py 70.07% <51.13%> (-0.23%) ⬇️
pypuppetdb/utils.py 93.75% <80.00%> (-0.70%) ⬇️
pypuppetdb/api/pql.py 85.00% <90.90%> (-0.49%) ⬇️
pypuppetdb/QueryBuilder.py 97.09% <95.00%> (-0.03%) ⬇️
pypuppetdb/__init__.py 100.00% <100.00%> (ø)
pypuppetdb/api/base.py 98.42% <100.00%> (-0.03%) ⬇️
pypuppetdb/api/command.py 94.11% <100.00%> (-0.33%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gdubicki gdubicki changed the title Modernize to Python 3.7+ with pyupgrade Modernize code Nov 2, 2022
@gdubicki gdubicki marked this pull request as ready for review November 2, 2022 22:54
@gdubicki gdubicki changed the title Modernize code Modernize the code Nov 2, 2022
@gdubicki gdubicki merged commit a73bee3 into master Nov 3, 2022
@gdubicki gdubicki deleted the modernize_py37 branch November 3, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants