Add option to get nodes without using event-counts #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See voxpupuli/puppetboard#430 and voxpupuli/puppetboard#149 for more context about this query being slow. |
|
This seems reasonable but you broke the line length requirement now. Could you fix that please? See the CI logs. |
As event-counts query may be very slow and has experimental status it is beneficial for some users to get nodes without exact number of changes resources in the last report for compatibility and performance benefit.
gdubicki
force-pushed
the
nodes_query_optionally_without_event_counts
branch
from
e5b27a1 to
3d36e90
Compare
Fixed. |
|
Thanks @gdubicki ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As event-counts query may be very slow and has experimental
status it is beneficial for some users to get nodes without
exact number of changed resources in the last report
for compatibility and performance benefit.