Allow usage of unauthenticated PuppetDB over SSL #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
1 similar comment
|
+1 |
|
CLA signed by all contributors. |
|
Anyone from @voxpupuli could have a look at this, perhaps add a comment if you're not happy with the change? |
|
@cassianoleal Sorry for the delay on this. Could you rebase your PR off master? Once done, I'll finish looking at this. |
added 2 commits
July 17, 2017 15:31
On some occasions the user might have a PuppetDB installation serving the API from an SSL-enabled server but with no authentication mechanism. In these cases the pem settings are not necessary and should be avoided.
|
@dhollinger I have rebased and updated the specs. All tests are passing. I've stopped using Puppet altogether and don't have a real PuppetDB installation to test this against but other people seem to want this capability as well so I made the effort. If there's anything to improve please let me know. |
|
@cassianoleal Thanks! I'm going to bring this topic up in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some occasions the user might have a PuppetDB installation serving the API from an SSL-enabled server with no authentication mechanism. In these cases the pem settings are not necessary and should be avoided.