Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using default SECRET_KEY and prepare 5.0.0 release #909

Merged
merged 3 commits into from
Jul 27, 2023

Conversation

gdubicki
Copy link
Contributor

@gdubicki
Copy link
Contributor Author

Thanks @bastelfreak, but let me fix the tests before we merge it.

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 55.55% and project coverage change: -0.29% ⚠️

Comparison is base (c8366ec) 77.15% compared to head (f3233f6) 76.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #909      +/-   ##
==========================================
- Coverage   77.15%   76.87%   -0.29%     
==========================================
  Files          20       20              
  Lines        1309     1310       +1     
==========================================
- Hits         1010     1007       -3     
- Misses        299      303       +4     
Files Changed Coverage Δ
puppetboard/app.py 82.85% <0.00%> (-1.43%) ⬇️
puppetboard/utils.py 90.32% <0.00%> (-3.16%) ⬇️
puppetboard/core.py 79.31% <100.00%> (ø)
puppetboard/default_settings.py 100.00% <100.00%> (ø)
puppetboard/docker_settings.py 100.00% <100.00%> (ø)
puppetboard/version.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdubicki gdubicki marked this pull request as ready for review July 27, 2023 11:40
@gdubicki gdubicki merged commit 895030f into master Jul 27, 2023
@gdubicki gdubicki deleted the release_5.0.0 branch July 27, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants