Pin and update dependencies #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to prevent possible issues and easier troubleshooting.
Codecov ReportBase: 85.55% // Head: 85.55% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #728 +/- ##
=======================================
Coverage 85.55% 85.55%
=======================================
Files 19 19
Lines 1087 1087
=======================================
Hits 930 930
Misses 157 157 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
as the former had conflicting dependencies with other packages. This pinning is needed as sometimes installing test dependencies is super slow in CI/CD because pip has to resolve a matching set of versions (I observed even a >20 minutes running time and a timeout).
bastelfreak
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In voxpupuli/puppet-puppetboard#374 (comment) I noticed that we have quite a different versions of packages. And with the way we manage this app in that Puppet module, updating the app will NOT trigger dependencies update (f.e.
certifipackage, which should be kept up to date).If we pin specific versions of the dependencies AND keep them up to date with Dependabot (which we will enable in this repo after this PR), then updating the Puppetboard will update those packages and ensure that all users of the same Puppetboard version have the same dependencies.