Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start warning about upcoming SECRET_KEY default removal #726

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

gdubicki
Copy link
Contributor

@gdubicki gdubicki commented Dec 5, 2022

Related to #721

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 85.43% // Head: 85.50% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (f5d29f5) compared to base (9c41b29).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #726      +/-   ##
==========================================
+ Coverage   85.43%   85.50%   +0.06%     
==========================================
  Files          19       19              
  Lines        1078     1083       +5     
==========================================
+ Hits          921      926       +5     
  Misses        157      157              
Impacted Files Coverage Δ
puppetboard/app.py 83.33% <100.00%> (+0.25%) ⬆️
puppetboard/default_settings.py 100.00% <100.00%> (ø)
puppetboard/docker_settings.py 100.00% <100.00%> (ø)
puppetboard/utils.py 93.18% <100.00%> (+0.24%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gdubicki gdubicki merged commit c605c43 into master Dec 8, 2022
@gdubicki gdubicki deleted the warn_about_secret_key branch December 8, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants