Add/ubuntu24 #955
Open
Add/ubuntu24 #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Jun 27, 2024
| @@ -13,7 +13,7 @@ def baseline_os_hash | |||
| }, | |||
| { | |||
| 'operatingsystem' => 'Ubuntu', | |||
| 'operatingsystemrelease' => %w[20.04 22.04] | |||
| 'operatingsystemrelease' => %w[20.04 22.04 24.04] | |||
There was a problem hiding this comment.
I think in another PR we should remove the whole hash here. It doesn't make sense to duplicate the information from metadata.json. We did that in the past because we only had limited CI power.
There was a problem hiding this comment.
yes but we need to remove not supported os from metadata.json
I'm waiting centos7 EOL to think to release v11
There was a problem hiding this comment.
FYI: With #967 the unit tests will run much faster, so we don't need to worry about the CI runtime for unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Add Ubuntu 24.04 to supported OS
This Pull Request (PR) fixes the following issues
This Pull Request (PR) include
#952