Clean up PostgreSQL DB creation logic #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
approved these changes
Nov 6, 2023
evgeni
reviewed
Nov 7, 2023
evgeni
reviewed
Nov 7, 2023
evgeni
reviewed
Nov 7, 2023
evgeni
reviewed
Nov 7, 2023
evgeni
approved these changes
Nov 7, 2023
|
ACK, but not going to merge, @ekohl might or might not want to squash my fixups into the right real commits ;) |
This uses nesting and inheritance to provide a context and further refine it. It also drops the case where it always provided the default database port and a specific example without it. It now only tests the case where it's provided no database port and a custom one.
Fixes: b1f38dd ("Drop Zabbix 2/3/4.2/4.4 support")
This makes the commands easier and doesn't require to store the password plain text in a file.
This also uses the creates option for exec.
This uses zcat and a pipe to unpack the file on the fly.
This is not used anywhere within the class and only slows things down.
|
I did want to squash those up. I also extended the |
evgeni
approved these changes
Nov 7, 2023
bastelfreak
approved these changes
Nov 7, 2023
This was referenced Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started with the goal of getting rid of /root/.pgpass and instead use environment variables, but it escalated. See individual commits for details.