Skip to content

Commit

Permalink
gha-puppet v2
Browse files Browse the repository at this point in the history
  • Loading branch information
evgeni committed Oct 20, 2023
1 parent 80cfdfb commit db2a380
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 5 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ concurrency:
jobs:
puppet:
name: Puppet
uses: voxpupuli/gha-puppet/.github/workflows/beaker.yml@v1
uses: voxpupuli/gha-puppet/.github/workflows/beaker.yml@v2
with:
pidfile_workaround: 'false'
beaker_facter: 'zabbix_version:Zabbix:5.0,6.0'
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ on:
jobs:
release:
name: Release
uses: voxpupuli/gha-puppet/.github/workflows/release.yml@v1
uses: voxpupuli/gha-puppet/.github/workflows/release.yml@v2
with:
allowed_owner: 'voxpupuli'
secrets:
Expand Down
2 changes: 2 additions & 0 deletions .sync.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ spec/spec_helper.rb:
.puppet-lint.rc:
enabled_lint_checks:
- parameter_documentation
.github/workflows/ci.yml:
beaker_facter: 'zabbix_version:Zabbix:5.0,6.0'
4 changes: 2 additions & 2 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ group :test do
gem 'voxpupuli-test', '~> 7.0', :require => false
gem 'coveralls', :require => false
gem 'simplecov-console', :require => false
gem 'puppet_metadata', '~> 3.0', :require => false
gem 'puppet_metadata', '~> 3.5', :require => false
gem 'fakefs', :require => false
gem 'zabbixapi', :require => false
end
Expand All @@ -18,7 +18,7 @@ group :development do
end

group :system_tests do
gem 'voxpupuli-acceptance', '~> 2.0', :require => false
gem 'voxpupuli-acceptance', '~> 2.2', :require => false
end

group :release do
Expand Down
3 changes: 2 additions & 1 deletion spec/support/acceptance/supported_versions.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# frozen_string_literal: true

def supported_versions
%w[5.0 6.0]
# this is a hack so that we don't have to rewrite the other tests
[ENV['BEAKER_FACTER_ZABBIX_VERSION']]

Check failure on line 5 in spec/support/acceptance/supported_versions.rb

View workflow job for this annotation

GitHub Actions / Puppet / Static validations

Style/FetchEnvVar: Use `ENV.fetch('BEAKER_FACTER_ZABBIX_VERSION')` or `ENV.fetch('BEAKER_FACTER_ZABBIX_VERSION', nil)` instead of `ENV['BEAKER_FACTER_ZABBIX_VERSION']`. (https://rubystyle.guide/#hash-fetch-defaults)
end

0 comments on commit db2a380

Please sign in to comment.