Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace legacy facts #344

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Replace legacy facts #344

merged 1 commit into from
Dec 12, 2024
+6 −6

Conversation

bastelfreak
Copy link
Member

resubmission of #337

@jay7x
Copy link
Member

jay7x commented Dec 12, 2024 •
edited
Loading

LGTM, but unit tests are failing 🤔
Ah, I roughly remember confine was not really working for me with structured facts.. maybe different syntax, not sure..

@voreilly @bastelfreak
Replace legacy facts
c13dfcf 
Update legacy facts
@bastelfreak bastelfreak added the bug Something isn't working label Dec 12, 2024
@bastelfreak bastelfreak merged commit 34f9ef5 into voxpupuli:master Dec 12, 2024
21 checks passed
@bastelfreak bastelfreak deleted the facts branch December 12, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheMeier TheMeier TheMeier approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bastelfreak @jay7x @TheMeier @voreilly