Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use simpler code for tests for expected failures #173

Merged
merged 1 commit into from
Jun 27, 2020

Conversation

traylenator
Copy link

Pull Request (PR) description

Rather than:

 it { is_expected.to raise_error(Puppet::PreformattedError,
       `%r{Package name must be formatted as Yum::RpmName, not 'String'}
      )
 }

use

it { is_expected.to compile.and_raise_error(
   %r{Package name must be formatted as Yum::RpmName, not 'String'}
)}

Rather than:

```ruby
 it { is_expected.to raise_error(Puppet::PreformattedError,
       `%r{Package name must be formatted as Yum::RpmName, not 'String'}
                     )
 }
```

use

```ruby
it { is_expected.to compile.and_raise_error(
   %r{Package name must be formatted as Yum::RpmName, not 'String'}
)}
```
@traylenator traylenator added the enhancement New feature or request label May 18, 2020
@bastelfreak bastelfreak merged commit 8b7c297 into voxpupuli:master Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants