enable buffered logs #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
requested changes
Jan 21, 2018
templates/squid.conf.header.erb
Outdated
| @@ -13,6 +13,7 @@ maximum_object_size_in_memory <%= @maximum_object_size_in_memory %> | |||
| <% if @logformat -%> | |||
| logformat <%= @logformat %> | |||
| <% end -%> | |||
| buffered_logs <%= (@buffered_logs == 'on' || @buffered_logs == true)?'on':'off' %> | |||
There was a problem hiding this comment.
Probably best to wrap this in
unless @buffered_logs.nil?
and default the parameter to undef.
alexjfisher
reviewed
Jan 21, 2018
templates/squid.conf.header.erb
Outdated
| @@ -13,7 +13,9 @@ maximum_object_size_in_memory <%= @maximum_object_size_in_memory %> | |||
| <% if @logformat -%> | |||
| logformat <%= @logformat %> | |||
| <% end -%> | |||
| buffered_logs <%= (@buffered_logs == 'on' || @buffered_logs == true)?'on':'off' %> | |||
| <% unless @memory_cache_shared.nil? -%> | |||
| buffered_logs <%= (@buffered_logs == true)?'on':'off' %> | |||
There was a problem hiding this comment.
I guess the == true isn't needed?
alexjfisher
requested changes
Jan 25, 2018
templates/squid.conf.header.erb
Outdated
| @@ -13,6 +13,9 @@ maximum_object_size_in_memory <%= @maximum_object_size_in_memory %> | |||
| <% if @logformat -%> | |||
| logformat <%= @logformat %> | |||
| <% end -%> | |||
| <% unless @memory_cache_shared.nil? -%> | |||
|
@alexjfisher |
traylenator
added
enhancement
alexjfisher
previously approved these changes
Feb 17, 2018
|
@SourceDoctor Looks good. Could you rebase please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Option to enable buffering logs before writing to disc