add url_rewrite feature #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
requested changes
Jan 21, 2018
| @@ -15,6 +15,7 @@ | |||
| $auth_params = $::squid::auth_params, | |||
| $http_ports = $::squid::http_ports, | |||
| $https_ports = $::squid::https_ports, | |||
| $url_rewrite_program = $::squid::url_rewrite_program, | |||
There was a problem hiding this comment.
Looks like you've forgotten to edit init.pp
manifests/config.pp
Outdated
| @@ -60,6 +61,9 @@ | |||
| if $cache_dirs { | |||
| create_resources('squid::cache_dir', $cache_dirs) | |||
| } | |||
| if $url_rewrite_program { | |||
| create_resources('squid::url_rewrite_program', $url_rewrite_program) | |||
There was a problem hiding this comment.
since it's url_rewrite_program singular, I'm assuming this will be a string? (and therefore create_resources isn't what you'll need).
There was a problem hiding this comment.
everything done, something else to handle or ready to merge?
traylenator
reviewed
Feb 15, 2018
| @@ -0,0 +1,5 @@ | |||
| # fragment for url_rewrite_program <%= @program %> | |||
| url_rewrite_program <%= @program %> | |||
| <% unless @children.nil? -%> | |||
There was a problem hiding this comment.
To be consistant the simpler
<% if @children %>
siince it's an Integer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add missing URL-Rewrite Feature for using squidguard or other stuff